PR #2171: review-to-check coverage matrix#

Audit head: 858b174a65f160d13d01f0324c7481cc8e4eba3a. This is a self-review of the proposed checks, with temporary executable probes. No production repair or permanent oracle extension was made in this audit.

The answer to “would the original 15 catch everything?” is no. The expanded plan has 26 checks. This matrix accounts for 53 findings and four evidence caveats. Accounting is not proof that all checks intercept their targets. Known current failures keep those laws open, even though their existing narrower oracles pass.

Laws, experiments, and remaining enforcement#

No law change needs a new maintainer decision. Independent cached callers reject conflicting local row options. Mounted hooks retain inline options until identity changes. Metadata follows authoring shape, with the last present structured spread winning. New functional objects receive output metadata; direct source returns retain source metadata. Inline values keep authored shape. Query and Electric ignore legacy runtime returns, and their types reject them. Query does no automatic refetch. The maintainer explicitly selected a stable Query minor and coordinated RC DB peers for the accidentally stable Query/Offline packages.

The probe inputs, checkpoint construction, commands, setup failure, and logs are described in the expanded plan's follow-up experiment section. These are RED witnesses, with compatible controls. They are not repair GREEN results.

Source inventory and evidence notation#

• A01–A15: first pasted review, preserved in the task attachment Pasted text.txt. Its reviewer read the worktree diff and Changesets 6.0.9, queried published manifests, and ran no tests. Original line references are retained below; that review supplied no commit SHA.
• B01–B10: next supplied review, evaluated from 7c53f271a in the first versioned evaluation. B10 has two subclaims, both retained here.
• C01–C15: latest supplied review, targeting 0a60ad85b; evaluated from 66454803b with repairs in 68228aaf3. The second versioned evaluation records original claims, repros, mutants, and limits. C01 includes core and React paths.
• G01–G11: seven inline comments, three outside-diff findings, and one additional prose suggestion in GitHub's two reviews. First review covers through 66454803b; second through the audit head. Stable links identify inline comments. Outside-diff findings are in the corresponding review body.
• W01–W02: the two warnings in the bot's mutable walkthrough, inspected at the audit head. Its merge-risk summary repeats G05/G08/G09/G10; it is not another independent finding.

O01–O26 refer to the numbered checks in the expanded plan. Their owner, independent judgment, legal histories, cut, and distinguishing experiment are specified there. They are proposals except where the evidence explicitly says an existing owner already executes them.

Historical means the linked evaluation records the experiment at its own head; this audit did not replay every original fault. Source means direct source inspection, not an executed behavior/build failure. Current RED means an intended assertion failed at this audit head. Proposed means the broader check has not run. already-fixed and stale describe the reported trace; they do not close the broader unimplemented improvements.

A: first supplied review#

The source calls A01–A04 high severity. A05–A08 are release follow-ons, A09–A11 correctness findings, and A12–A15 design/cleanup/docs findings.

B: next supplied review#

Original paths/lines refer to its reviewed tree. B01/B03–B08 are behavioral or compatibility findings; B09/B10 include cleanup and production-error concerns.

C: latest supplied review#

The reviewer reported executed repros for C01–C05 and source-only packaging claims C06–C08. The second evaluation distinguishes observed results from specific TypeError/ERESOLVE predictions.

G: GitHub review comments#

Inline comments link to their stable source. G08 is outside the first review's diff; G09/G10 are outside the second review's diff. G11 is the second review's separate “additional/unverified” wording suggestion. The reviewers' current line references below are checked against the audit head, not assumed from old inline positions.

W: bot walkthrough warnings#

Four evidence caveats#

Loss accounting, reviewer quality, and closeout#

The initial scratch ledger was created before probes. Final raw-source reconciliation corrected G07's conflation with the distinct G11 suggestion and added the two walkthrough warnings. No review finding was removed to make the count fit. Multiple subclaims remain within B10/C01 and are explicitly mapped. The four caveats are additional to the 53 finding IDs.

Numbered-row accounting is 53 = 29 already-fixed + seven stale + three accepted-design + five duplicate + seven confirmed-open + two refuted. B10 is counted once as stale for its older shared-policy claim; its distinct coded-error subclaim is already fixed. C01 counts once but retains both core and React paths. No row is deferred. No new product policy is adopted here; A12 requires contract inspection before extending assertions to Effects. These totals classify reported traces, not the completion of all proposed checks. In particular, the seven confirmed-open rows are G01, G05, G07–G11; G07/G11 are editorial, G05/G08 have source evidence, and G01/G09/G10 have executed behavioral failures.

The first reviewer had useful source-based boundary analysis but no runtime confirmation. Later reviewers supplied strong executable counterexamples and honest setup/scope disclosures. The GitHub review identified two real cache paths missed by the current driver. Policy recommendations still need the maintainer decisions: a major Query bump, post-write rejection, and scope splitting do not follow from those defects. These reviewers are useful for defect discovery; their proposed fixes and coverage claims still need checking.

Recommendation: hire for defect discovery, with policy and evidence calibration. Their reproducible boundary failures are the strongest evidence. An unconfigured metric or a scope judgment that omits maintainer instructions does not establish a required repair.

The expanded plan accounts for every identified finding in these sources. It does not establish that its proposed checks have caught every original implementation. Each behavioral row still needs its original failure or a plausible mutant to fail at the named comparison before that claim is earned. Static findings need source/build/declaration evidence instead. O16 and the hydration part of O04 have current RED evidence; G01 has an executed docs receiver. Those three confirmed failures remain unfixed in this audit. G05/G08 need their clean build/typecheck witnesses. Broader proposals remain open in the coverage map.

The PR is not ready on this evidence: G09/G10 violate the accepted cache law, and G01 teaches an unconfirmed successful mutation. This audit identifies repairs and checks; it does not postpone them by agreement, retire those laws, or claim completed implementation. No guarantee of zero future findings is justified by a complete matrix or a passing random campaign.

Final inventory assertions pass: 53 unique finding IDs, four caveats, 26 check definitions, and a mapped check for every row. The final read-only GitHub query returned the same head, two review bodies, and five general comment bodies, all unchanged from the first snapshot. Changed-file lint, report formatting, and git diff --check pass. pnpm reports the existing lockfile/installed override mismatch; no dependency installation or override change was made.

Additional findings during oracle construction#

These append to the original inventory; they do not replace or renumber its 53 findings. Production remains at 858b174a65f160d13d01f0324c7481cc8e4eba3a.

P01 evidence: chunk13-publish-independent-final.log under /private/tmp/rc2171-oracle-challenge/. P02 was independently identified during read-only O20/O21 preparation. The existing typed live-query schema limitation is already recorded in the coverage map; it is not relabeled as a newly confirmed regression here. A scratch schema-role experiment establishes that client mutation inputs, rather than synced rows, are the appropriate receiving boundary for a future transforming-schema retention check.

P03 (existing replay instrumentation): recordOracleReplay is documented as never throwing, but a real fc.check RunDetails value and an unwritable witness channel (a directory) produce EISDIR from its synchronous writer. The finite comparison wrapper added in chunk 13 preserves both primary and writer errors; that evidence does not establish the older standalone recorder's intended policy. The guarded replay/standalone recorder owner must resolve this existing comment/behavior conflict before claiming a broader writer-failure guarantee. Independent probe: chunk13-old-record-writer-probe.log in the scratch evidence directory. No library production repair was made.

G08 clarification and current receiver: the unchanged bad handler at packages/db-sqlite-persistence-core/tests/persisted-source-receipts.test.ts:957 is a plain persisted Collection handler, not Query-specific. Core Collection insert/update/delete handlers all require Promise<void>. Running that package's actual tsc --noEmit --project tsconfig.json (which maps DB to current source) produces the intended TS2769 handler diagnostic plus its cascading call-site diagnostic. Evidence: o22-persisted-core-source-types-baseline.log. Offline's missing workspace DB build edge is separately demonstrated by pnpm's filtered project closure; its committed lock already contains a DB link, so this finding does not by itself prove frozen installation fails.

P10 final independent receiving evidence: chunk 17 now has 580 tests, 377 passes/203 intended correlated-child callback-law REDs, with all 2,153 declared states reached. All 203 failures are the expected law exception, not setup/runtime failures. Controls and valid replay-environment/partial selection checks pass their intended judgments; production remains unfixed. The earlier 575-test author run above is retained historical evidence.

P11 runtime authority and receiving evidence are now resolved by independently accepted chunk 19. The public builder explicitly promises literal null/undefined pass-through and recursive record selection. Eight of its 68 exact typed root/QueryRef histories fail because raw selected undefined becomes null, including mixed arrays. All three ready cuts, public events and callback inputs are retained. Public type accuracy and correlated receiving paths remain next gates; a broader mixed-expression type-admission diagnostic remains unresolved.

Chunk 19's unchanged production run has 103 tests: 85 pass and 18 intended assertion REDs (eight P11 plus ten P12), with all 306 states reached once. Independent review repaired only a missing oracle declaration, verified the semantic-neutral delta, strict driver admission and immutable capture controls. This is accepted instrument coverage; it does not close these product defects or change the original 53-finding accounting. P13/P14 read-only preparation and exact-source evidence are retained in the O21 scratch plan.

P11/P12 correlated receiving evidence: independently accepted chunk 20 runs 272 exact legal histories through both array spellings, singleton and facade materialization. All 3,264 declared states execute once; 200 histories pass and 72 preserve the same literal-law REDs, with no driver-execution failures. The 33 checker controls and six independent facet-isolation controls pass. Public inferred types remain the next gate. Original QueryRef fixtures missing their own correlation WHERE are retained as documented missing-premise evidence, not value-law failures. No production or guidance repair has occurred.